[KeyVault] - Address KeyVault feedback#13524
Conversation
- Hide various parse identifier methods - Make additionalAuthenticatedData readonly
sadasant
left a comment
There was a problem hiding this comment.
Looks good to me! Very concise.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/check-enforcer override
|
What
Why
These came out of the recent KV architecture review. I spoke to @sadasant and
made sure that the other tasks are not applicable to us
Callouts
The only thing I wasn't sure about is renaming EncryptOptions to EncryptParameters since I
think we already GA'd with EncryptOptions - should I add a new EncryptParameters where iv and aad
are set?
Partially resolves #13237